[firefly] [PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value

Daniel Baluta daniel.baluta at gmail.com
Wed Mar 12 14:06:05 EET 2014


>> Remove useless casting value returned by k[cmz]alloc
>> to (struct lpfc_sli_ring *).

> Did you find this error using some automated checker, like sparse of
> coccinelle? If so, it would be nice to mention that in the commit
> message.
> Other than this small nitpick, I have nothing else to remark.

Agree with Silviu. Commit message should look like this:

==
Remove useless casting value returned by k[cmz]alloc to (struct
lpfc_sli_ring *).
Found using coccinelle.
==

Also I think "scsi: Remove useless casting value, would be a better
commit subject"


thanks,
Daniel.


More information about the firefly mailing list