[firefly] [PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value

Silviu Popescu silviupopescu1990 at gmail.com
Wed Mar 12 12:42:24 EET 2014


On Wed, Mar 12, 2014 at 12:38 PM, Matei Oprea <eu at opreamatei.ro> wrote:
> Remove useless casting value returned by k[cmz]alloc
> to (struct lpfc_sli_ring *).
>
> Signed-off-by: Matei Oprea <eu at opreamatei.ro>
> Cc: ROSEdu Kernel Community <firefly at lists.rosedu.org>
> ---
>  drivers/scsi/lpfc/lpfc_init.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 68c94cc..47d2c20 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -4731,8 +4731,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
>         }
>
>         if (!phba->sli.ring)
> -               phba->sli.ring = (struct lpfc_sli_ring *)
> -                       kzalloc(LPFC_SLI3_MAX_RING *
> +               phba->sli.ring = kzalloc(LPFC_SLI3_MAX_RING *
>                         sizeof(struct lpfc_sli_ring), GFP_KERNEL);
>         if (!phba->sli.ring)
>                 return -ENOMEM;
> --
> 1.7.9.5
>
> _______________________________________________
> firefly mailing list
> firefly at lists.rosedu.org
> http://lists.rosedu.org/listinfo/firefly

Hi Matei,

Did you find this error using some automated checker, like sparse of
coccinelle? If so, it would be nice to mention that in the commit
message.
Other than this small nitpick, I have nothing else to remark.

Keep up the good work,
Silviu


More information about the firefly mailing list