[firefly] [ixlabs-dev] [PATCH RFC 3/7] ofproto: export update_port_config() for future use

[Daniel Baluta]

On Thu, Apr 10, 2014 at 8:20 PM, Alexandru Copot <alex.mihai.c at gmail.com> wrote:
> This function is needed by the OF1.4 bundles.
>
> Signed-off-by: Alexandru Copot <alex.mihai.c at gmail.com>
> Cc: Daniel Baluta <dbaluta at ixiacom.com>
> ---
>  ofproto/ofproto.c | 2 +-
>  ofproto/ofproto.h | 5 +++++
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index 2a0ed12..03a6713 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -2969,7 +2969,7 @@ exit:
>      return error;
>  }
>
> -static void
> +void
>  update_port_config(struct ofconn *ofconn, struct ofport *port,
>                     enum ofputil_port_config config,
>                     enum ofputil_port_config mask)
> diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h
> index f369ea5..18f59af 100644
> --- a/ofproto/ofproto.h
> +++ b/ofproto/ofproto.h
> @@ -50,6 +50,11 @@ enum ofperr
>  check_port_mod(struct ofconn *ofconn, const struct ofp_header *oh,
>                 struct ofputil_port_mod *pm, struct ofport **port);
>
> +void
> +update_port_config(struct ofconn *ofconn, struct ofport *port,
> +                   enum ofputil_port_config config,
> +                   enum ofputil_port_config mask);
> +
void should be on the same line with update_port_config.

>  struct ofproto_controller_info {
>      bool is_connected;
>      enum ofp12_controller_role role;

Otherwise, this looks good.