[firefly] [ixlabs-dev] [PATCH RFC 1/7] ofproto: allow marking ofport as part of a bundle

[Daniel Baluta]

On Thu, Apr 10, 2014 at 8:20 PM, Alexandru Copot <alex.mihai.c at gmail.com> wrote:
> Signed-off-by: Alexandru Copot <alex.mihai.c at gmail.com>
> Cc: Daniel Baluta <dbaluta at ixiacom.com>
> ---
>  ofproto/ofproto-provider.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/ofproto/ofproto-provider.h b/ofproto/ofproto-provider.h
> index 8c11aff..1d5ac3c 100644
> --- a/ofproto/ofproto-provider.h
> +++ b/ofproto/ofproto-provider.h
> @@ -54,6 +54,7 @@ struct ofpact;
>  struct ofputil_flow_mod;
>  struct bfd_cfg;
>  struct meter;
> +struct ofp_bundle;
>
>  extern struct ovs_mutex ofproto_mutex;
>
> @@ -176,6 +177,9 @@ struct ofport {
>      ofp_port_t ofp_port;        /* OpenFlow port number. */
>      long long int created;      /* Time created, in msec. */
>      int mtu;
> +
> +    atomic_bool is_updating;

We should remove 'is_updating' since now we are queuing all messages
while the bundle open.

> +    struct ofp_bundle *bundle;

Add a comment describing the role of bundle structure.

Otherwise looks good. Thanks Alex!