[firefly] [PATCH] Staging: crystalhd: Fix sparse warnings regarding static functions

Vlad Dogaru ddvlad at herebedragons.ro
Mon Oct 7 09:34:15 EEST 2013


On Sun, Oct 06, 2013 at 08:59:54PM +0300, Valentina Manea wrote:
> diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
> index b17fbf8..4d64759 100644
> --- a/drivers/staging/crystalhd/crystalhd_lnx.c
> +++ b/drivers/staging/crystalhd/crystalhd_lnx.c
> @@ -75,6 +75,7 @@ static int chd_dec_disable_int(struct crystalhd_adp *adp)
>  	return 0;
>  }
>  
> +static
>  struct crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
>  					 bool isr)

Maybe add static on the same line here?  Or split the line between the
return type and the function name?

>  {
> @@ -96,7 +97,7 @@ struct crystalhd_ioctl_data *chd_dec_alloc_iodata(struct crystalhd_adp *adp,
>  	return temp;
>  }
>  
> -void chd_dec_free_iodata(struct crystalhd_adp *adp,
> +static void chd_dec_free_iodata(struct crystalhd_adp *adp,
>  			 struct crystalhd_ioctl_data *iodata, bool isr)

This breaks the alignment of the following line.  You should probably
add tabs/spaces to the 'struct crystalhd_ioctl_data ...' line to keep it
aligned with the open parantheses.

Vlad


More information about the firefly mailing list