[firefly] [PATCH] Staging: crystalhd: Fix sparse warnings regarding static functions
daniel.baluta at gmail.com
Sun Oct 6 21:08:45 EEST 2013
On Sun, Oct 6, 2013 at 8:59 PM, Valentina Manea
<valentina.manea.m at gmail.com> wrote:
> This fixes the following sparse warnings:
> * drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning:
> symbol 'chd_dec_alloc_iodata' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning:
> symbol 'chd_dec_free_iodata' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:630:5: warning:
> symbol 'chd_dec_pci_suspend' was not declared. Should it be static?
> * drivers/staging/crystalhd/crystalhd_lnx.c:664:5: warning:
> symbol 'chd_dec_pci_resume' was not declared. Should it be static?
> Signed-off-by: Valentina Manea <valentina.manea.m at gmail.com>
Looks good to me. Please don't forget to CC Greg KH when sending
patches to opw list.
Also, for the next patches if the number of 'Should it be static?'
errors is large enough
don't specify each of the errors in the commit message. Just the first
one should be fine.
More information about the firefly