[firefly] [PATCH] fnic: use simple_open

Valentina Manea valentina.manea.m at gmail.com
Sat Oct 5 15:22:45 EEST 2013

On Sat, Oct 5, 2013 at 3:15 PM, Camelia Groza <camelia.groza at gmail.com> wrote:
> On Sat, Oct 5, 2013 at 2:09 PM, Valentina Manea
> <valentina.manea.m at gmail.com> wrote:
>> fnic_trace_ctrl_open() is a duplicated implementation
>> of simple_open(). Since the common implementation
>> has been moved to libfs, simple_open() should be used.
> I submitted a similar patch a couple of months ago [1] but it didn't
> get integrated. Maybe you'll have better luck :).
> [1] https://lkml.org/lkml/2013/7/12/465
> Camelia

You did get an ack on it, I'm guessing they forgot (?) about it.
This change has been in a massive patch in 2012 but this file was
added in 2013; it should be accepted.

Any other opinions are welcome.


More information about the firefly mailing list