[firefly] [PATCH] madvise: fix checkpatch errors

Daniel Baluta daniel.baluta at gmail.com
Thu Jul 11 09:53:39 EEST 2013


On Thu, Jul 11, 2013 at 9:51 AM, Vladimir Cernov <gg.kaspersky at gmail.com> wrote:
> This fixes following errors:
>         - ERROR: "(foo*)" should be "(foo *)"
>         - ERROR: "foo ** bar" should be "foo **bar"
>
> Signed-off-by: Vladimir Cernov <gg.kaspersky at gmail.com>
> ---
>  mm/madvise.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/mm/madvise.c b/mm/madvise.c
> index 7055883..936799f 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -42,11 +42,11 @@ static int madvise_need_mmap_write(int behavior)
>   * We can potentially split a vm area into separate
>   * areas, each area with its own behavior.
>   */
> -static long madvise_behavior(struct vm_area_struct * vma,
> +static long madvise_behavior(struct vm_area_struct *vma,
>                      struct vm_area_struct **prev,
>                      unsigned long start, unsigned long end, int behavior)
>  {
> -       struct mm_struct * mm = vma->vm_mm;
> +       struct mm_struct *mm = vma->vm_mm;
>         int error = 0;
>         pgoff_t pgoff;
>         unsigned long new_flags = vma->vm_flags;
> @@ -215,8 +215,8 @@ static void force_shm_swapin_readahead(struct vm_area_struct *vma,
>  /*
>   * Schedule all required I/O operations.  Do not wait for completion.
>   */
> -static long madvise_willneed(struct vm_area_struct * vma,
> -                            struct vm_area_struct ** prev,
> +static long madvise_willneed(struct vm_area_struct *vma,
> +                            struct vm_area_struct **prev,
>                              unsigned long start, unsigned long end)
>  {
>         struct file *file = vma->vm_file;
> @@ -270,8 +270,8 @@ static long madvise_willneed(struct vm_area_struct * vma,
>   * An interface that causes the system to free clean pages and flush
>   * dirty pages is already available as msync(MS_INVALIDATE).
>   */
> -static long madvise_dontneed(struct vm_area_struct * vma,
> -                            struct vm_area_struct ** prev,
> +static long madvise_dontneed(struct vm_area_struct *vma,
> +                            struct vm_area_struct **prev,
>                              unsigned long start, unsigned long end)
>  {
>         *prev = vma;
> @@ -459,7 +459,7 @@ madvise_behavior_valid(int behavior)
>  SYSCALL_DEFINE3(madvise, unsigned long, start, size_t, len_in, int, behavior)
>  {
>         unsigned long end, tmp;
> -       struct vm_area_struct * vma, *prev;
> +       struct vm_area_struct *vma, *prev;
>         int unmapped_error = 0;
>         int error = -EINVAL;
>         int write;

Looks good. Thanks Vladimir.


More information about the firefly mailing list