[firefly] [PATCH] lguest: fix comments in lguest_cpuid function.

Daniel Baluta daniel.baluta at gmail.com
Sun Apr 21 20:54:12 EEST 2013


On Sun, Apr 21, 2013 at 3:15 PM, Cosmin Paraschiv <csmnprschv at gmail.com> wrote:
> On 04/21/2013 03:02 PM, Daniel Baluta wrote:
>>
>> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
>> index 1cbd89c..d837c18 100644
>> --- a/arch/x86/lguest/boot.c
>> +++ b/arch/x86/lguest/boot.c
>> @@ -435,8 +435,8 @@ static void lguest_cpuid(unsigned int *ax, unsigned
>> int *bx,
>>          /*
>>           * CPUID 1 is a basic feature request.
>>           *
>> -        * CX: we only allow kernel to see SSE3, CMPXCHG16B and SSSE3
>> -        * DX: SSE, SSE2, FXSR, MMX, CMOV, CMPXCHG8B, TSC, FPU and PAE.
>> +        * CX: we only allow kernel to see SSE3, CMPXCHG16B and SSSE3.
>> +        * DX: SSE, SSE2, FXSR, MMX, CMOV, CMPXCHG8, TSC, FPU and PAE.
>> So CMPXCHG16B doesn't have an extra B? what about CMPXCHG8B?
>
>
> The first line merely adds a period at the end. As [1] and [2] state, the
> correct instructions' names are CMPXCHG8 and CMPXCHG16B.

Ok. Looks good. Hope that Rusty won't get rusty about the period at
the end of the first line.

thanks,
Daniel.


More information about the firefly mailing list