[firefly] [PATCH] lguest: fix comments in lguest_cpuid function.

Cosmin Paraschiv csmnprschv at gmail.com
Sun Apr 21 15:15:27 EEST 2013


On 04/21/2013 03:02 PM, Daniel Baluta wrote:
> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> index 1cbd89c..d837c18 100644
> --- a/arch/x86/lguest/boot.c
> +++ b/arch/x86/lguest/boot.c
> @@ -435,8 +435,8 @@ static void lguest_cpuid(unsigned int *ax, unsigned int *bx,
>          /*
>           * CPUID 1 is a basic feature request.
>           *
> -        * CX: we only allow kernel to see SSE3, CMPXCHG16B and SSSE3
> -        * DX: SSE, SSE2, FXSR, MMX, CMOV, CMPXCHG8B, TSC, FPU and PAE.
> +        * CX: we only allow kernel to see SSE3, CMPXCHG16B and SSSE3.
> +        * DX: SSE, SSE2, FXSR, MMX, CMOV, CMPXCHG8, TSC, FPU and PAE.
> So CMPXCHG16B doesn't have an extra B? what about CMPXCHG8B?

The first line merely adds a period at the end. As [1] and [2] state, 
the correct instructions' names are CMPXCHG8 and CMPXCHG16B.

Thanks,
Cosmin Paraschiv

[1] http://lxr.linux.no/#linux+v3.8/arch/x86/include/asm/cpufeature.h#L28
[2] 
http://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits


More information about the firefly mailing list