[vmchecker-dev] [codereview]

[Lucian Adrian Grijincu]

On Tue, Apr 28, 2009 at 12:30 AM, Alexandru Moșoi <brtzsnr at gmail.com> wrote:
> & a few more :)

& more:

Stupid github doesn't allow CRs for newly added files.
http://github.com/ironmissy/vmchecker/blob/886490fd58d1de117e00e4dfc1695a27c3987251/bin/submissions.py
    location = vmcheckerpaths.dir_user(assignment, user)
    config_file = os.path.join(location, 'config')

I know this isn't your code, but I've seen it done in a few places.
This shoud lie in a function of it's own kind:

I think a call like
   vmcheckerpaths.assignment_config(user=u, assigment=as)
would be nice, or we could drop the dictionary args and use plain old
   vmcheckerpaths.assignment_config(u, as)


./commander.py:    args = (join(dir, 'callback'), join(dir, 'config'))
./commander.py:    with open(join(dir, 'config')) as handle:
./commander.py:    needed_files = ['archive.zip', 'tests.zip',
'config', 'storer', 'callback']
./repo_walker.py:        if not os.path.isfile(os.path.join(path, 'config')):
./submit.py:    with open(os.path.join(location, 'config'), 'w') as handler:
./submit.py:    with open(os.path.join(location, 'config')) as handler:
./submit.py:                zip_.write(os.path.join(location,
'config'), 'config')
./submit.py:    config_file = os.path.join(location, 'config')
./submit.py:    with open(os.path.join(location, 'config')) as handler:

-- 
 .
..: Lucian