[robocheck-dev] Ping

Constantin Mihalache mihalache.c94 at gmail.com
Tue Oct 20 19:25:42 EEST 2015


On 20 October 2015 at 08:38, Laura Vasilescu <laura at rosedu.org> wrote:
> On Tue, Oct 20, 2015 at 12:04 AM, Andrei Tuicu <andrei.tuicu at gmail.com> wrote:
>> @Laura: I would suggest giving Constantin commit and merge rights for the
>> repository. I haven't wrote much Python ever since this project and I feel
>> like I'm slowing things down here rather than helping. While I still do
>> encourage that he submits pull requests, so we can discuss things from a
>> functional perspective, or design choices, something missing, etc., I think
>> his contributions show that he can handle the responsibilities that come
>> from such great power. :) Also, a big plus is that he helped Theodor Stoican
>> make his first contribution. What do you think?
>
> Sure! I'll do this right away! :)
>
> Laura

First of all, thank you for trusting me with merge & commit rights to
the Robocheck repo. As Andrei said, I'll continue to contribute via
pull requests, so that we could discuss the design issues that may
arise.

Secondly, the test driven development style sounds appropriate, but
before starting to add new features, I remember we talked about
implementing a kind of common interface for the tools using
AbstractBaseClasses. If you agree this is the next step, my only
question is whether there should be only one interface - AbstractTool
- or three - AbstractTool, AbstractDynamicTool and Abstract StaticTool
- to emphasize the difference between the two types of tools.

Constantin


More information about the robocheck-dev mailing list