<div dir="ltr"><div><div>Thank you for the clarification about dev_info vs. dev_dbg.<br><br>struct tty_struct has a member struct device *dev.<br></div>If I use  dev_dbg(&tty->dev, .....), I`ll get the following warning:<br>note: expected ‘const struct device *’ but argument is of type ‘struct device **’. <br><br></div>Shoudn`t I use  dev_dbg(tty->dev, .....)?</div><div class="gmail_extra"><br><div class="gmail_quote">2014-09-14 21:15 GMT+03:00 Daniel Baluta <span dir="ltr"><<a href="mailto:daniel.baluta@gmail.com" target="_blank">daniel.baluta@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sun, Sep 14, 2014 at 6:15 PM, Roberta Dobrescu<br>
<<a href="mailto:roberta.dobrescu@gmail.com">roberta.dobrescu@gmail.com</a>> wrote:<br>
> This fixes the following <a href="http://checkpatch.pl" target="_blank">checkpatch.pl</a> warnings:<br>
> WARNING: printk() should include KERN_ facility level<br>
><br>
> Signed-off-by: Roberta Dobrescu <<a href="mailto:roberta.dobrescu@gmail.com">roberta.dobrescu@gmail.com</a>><br>
> ---<br>
> Changes since v1:<br>
> Used dev_info instead of netdev_dbg<br>
><br>
>  drivers/staging/dgnc/dgnc_tty.c | 4 ++--<br>
>  1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c<br>
> index 8920ae0..27589ab 100644<br>
> --- a/drivers/staging/dgnc/dgnc_tty.c<br>
> +++ b/drivers/staging/dgnc/dgnc_tty.c<br>
> @@ -2233,13 +2233,13 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)<br>
>         if (!bd || bd->magic != DGNC_BOARD_MAGIC)<br>
>                 return;<br>
><br>
> -       printk("dgnc_tty_send_xchar start\n");<br>
> +       dev_info(tty->dev, "dgnc_tty_send_xchar start\n");<br>
<br>
</span>This is too verbose. Please use dev_dbg instead of dev_info.<br>
First argument should be a pointer to the device:<br>
<br>
dev_dbg(&tty->dev, .....);<br>
<span class=""><br>
><br>
>         DGNC_LOCK(ch->ch_lock, lock_flags);<br>
>         bd->bd_ops->send_immediate_char(ch, c);<br>
>         DGNC_UNLOCK(ch->ch_lock, lock_flags);<br>
><br>
> -       printk("dgnc_tty_send_xchar finish\n");<br>
> +       dev_info(tty->dev, "dgnc_tty_send_xchar finish\n");<br>
</span>The same here.<br>
>         return;<br>
>  }<br>
<br>
thanks,<br>
Daniel.<br>
</blockquote></div><br></div>