<div dir="ltr"><div><div><div>Hello.<br><br></div>I have a question regarding patch 
submission. Should I reply to this thread with the modified patch or 
should I send a new patch with a subject like " [PATCH v2] 
include:linux: task_struct personality comment".<br><br></div>Thanks,<br></div>Andrei<br><br>---------- Forwarded message ----------<br><div><div><div><div><div class="gmail_quote">From: <b class="gmail_sendername">Ingo Molnar</b> <span dir="ltr"><<a href="mailto:mingo@kernel.org">mingo@kernel.org</a>></span><br>
Date: 10 April 2013 12:30<br>Subject: Re: [PATCH] include:linux: task_struct personality comment<br>To: Andrei Epure <<a href="mailto:epure.andrei@gmail.com">epure.andrei@gmail.com</a>><br>Cc: <a href="mailto:mingo@redhat.com">mingo@redhat.com</a>, <a href="mailto:peterz@infradead.org">peterz@infradead.org</a>, <a href="mailto:linux-kernel@vger.kernel.org">linux-kernel@vger.kernel.org</a>, <a href="mailto:trivial@kernel.org">trivial@kernel.org</a><br>
<br><br><div class="im"><br>
* Andrei Epure <<a href="mailto:epure.andrei@gmail.com">epure.andrei@gmail.com</a>> wrote:<br>
<br>
> Signed-off-by: Andrei Epure <<a href="mailto:epure.andrei@gmail.com">epure.andrei@gmail.com</a>><br>
> ---<br>
>  include/linux/sched.h |    4 +++-<br>
>  1 file changed, 3 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/include/linux/sched.h b/include/linux/sched.h<br>
> index d35d2b6..8621bb0 100644<br>
> --- a/include/linux/sched.h<br>
> +++ b/include/linux/sched.h<br>
> @@ -1274,8 +1274,10 @@ struct task_struct {<br>
>       int exit_code, exit_signal;<br>
>       int pdeath_signal;  /*  The signal sent when the parent dies  */<br>
>       unsigned int jobctl;    /* JOBCTL_*, siglock protected */<br>
> -     /* ??? */<br>
> +<br>
> +     /* used with exec_domain for compatibility with other UNIX-like OSs */<br>
>       unsigned int personality;<br>
<br>
</div>I don't mind documenting the p->personality flag, but in practice it's not used<br>
for emulation of other OSs really, but for emulating ABI behavior with previous<br>
_Linux_ versions, see include/uapi/linux/personality.h:<br>
<br>
 * Flags for bug emulation.<br>
 *<br>
 * These occupy the top three bytes.<br>
 */<br>
enum {<br>
        UNAME26 =               0x0020000,<br>
        ADDR_NO_RANDOMIZE =     0x0040000,      /* disable randomization of VA space */<br>
        FDPIC_FUNCPTRS =        0x0080000,      /* userspace function ptrs point to descriptors<br>
                                                 * (signal handling)<br>
                                                 */<br>
        MMAP_PAGE_ZERO =        0x0100000,<br>
        ADDR_COMPAT_LAYOUT =    0x0200000,<br>
        READ_IMPLIES_EXEC =     0x0400000,<br>
        ADDR_LIMIT_32BIT =      0x0800000,<br>
        SHORT_INODE =           0x1000000,<br>
        WHOLE_SECONDS =         0x2000000,<br>
        STICKY_TIMEOUTS =       0x4000000,<br>
        ADDR_LIMIT_3GB =        0x8000000,<br>
<br>
So the updated comment should say that.<br>
<br>
Thanks,<br>
<br>
        Ingo<br>
</div><br></div><div><br clear="all"></div><div><br>-- <br>Andrei Epure
</div></div></div></div></div>