[PATCH] media:atomisp:pci: Remove comparinson on bool tests

[Daniel Baluta]

On Sat, Mar 4, 2017 at 3:44 PM, Georgiana Rodica Chelu
<georgiana.chelu93 at gmail.com> wrote:
> Remove the comparison when a bool test to make the code easy to read.
>
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93 at gmail.com>

Looks good. For this exact kind of issue you can send the patch
directly  to outreachy list.
> ---
>  .../pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c     | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c
> index 0f1e8a2..f1fc3b5 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/virtual_isys.c
> @@ -331,7 +331,7 @@ static bool create_input_system_channel(
>                 break;
>         }
>
> -       if (rc == false)
> +       if (!rc)
>                 return false;
>
>         if (!acquire_sid(me->stream2mmio_id, &(me->stream2mmio_sid_id))) {
> @@ -474,7 +474,7 @@ static bool calculate_input_system_channel_cfg(
>
>         rc = calculate_stream2mmio_cfg(isys_cfg, metadata,
>                         &(channel_cfg->stream2mmio_cfg));
> -       if (rc == false)
> +       if (!rc)
>                 return false;
>
>         rc = calculate_ibuf_ctrl_cfg(
> @@ -482,7 +482,7 @@ static bool calculate_input_system_channel_cfg(
>                         input_port,
>                         isys_cfg,
>                         &(channel_cfg->ibuf_ctrl_cfg));
> -       if (rc == false)
> +       if (!rc)
>                 return false;
>         if (metadata)
>                 channel_cfg->ibuf_ctrl_cfg.stores_per_frame = isys_cfg->metadata.lines_per_frame;
> @@ -491,7 +491,7 @@ static bool calculate_input_system_channel_cfg(
>                         channel,
>                         isys_cfg,
>                         &(channel_cfg->dma_cfg));
> -       if (rc == false)
> +       if (!rc)
>                 return false;
>
>         rc = calculate_isys2401_dma_port_cfg(
> @@ -499,7 +499,7 @@ static bool calculate_input_system_channel_cfg(
>                         false,
>                         metadata,
>                         &(channel_cfg->dma_src_port_cfg));
> -       if (rc == false)
> +       if (!rc)
>                 return false;
>
>         rc = calculate_isys2401_dma_port_cfg(
> @@ -507,7 +507,7 @@ static bool calculate_input_system_channel_cfg(
>                         isys_cfg->raw_packed,
>                         metadata,
>                         &(channel_cfg->dma_dest_port_cfg));
> -       if (rc == false)
> +       if (!rc)
>                 return false;
>
>         return true;
> --
> 2.7.4
>