[PATCH 2/6] iio: hmc5843: Swap suspend and resume implementations

Daniel Baluta daniel.baluta at gmail.com
Sun Feb 7 21:31:13 EET 2016


Looks good. Make sure you always run ./scripts/ceckpatch.pl --strict
YOURpatch.patch :).

On Sun, Feb 7, 2016 at 8:15 PM, Cristina Moraru
<cristina.moraru09 at gmail.com> wrote:
> Swap implementations of hmc5843_common_suspend and
> hmc5843_common_resume functions for they have been
> inversed. Device should go on SLEEP mode on suspend
> and on CONTINUOUS mode on resume.
>
> Signed-off-by: Cristina Moraru <cristina.moraru09 at gmail.com>
> ---
>  drivers/staging/iio/magnetometer/hmc5843_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c
> index 4e2a7ec..dca8d64 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_core.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_core.c
> @@ -612,14 +612,14 @@ static const unsigned long hmc5843_scan_masks[] = {0x7, 0};
>  int hmc5843_common_suspend(struct device *dev)
>  {
>         return hmc5843_set_mode(iio_priv(dev_get_drvdata(dev)),
> -                       HMC5843_MODE_CONVERSION_CONTINUOUS);
> +                               HMC5843_MODE_SLEEP);
>  }
>  EXPORT_SYMBOL(hmc5843_common_suspend);
>
>  int hmc5843_common_resume(struct device *dev)
>  {
>         return hmc5843_set_mode(iio_priv(dev_get_drvdata(dev)),
> -                               HMC5843_MODE_SLEEP);
> +               HMC5843_MODE_CONVERSION_CONTINUOUS);
>  }
>  EXPORT_SYMBOL(hmc5843_common_resume);
>
> --
> 1.9.1
>


More information about the firefly mailing list