[PATCH] staging: comedi: Fix return flow

Daniel Baluta daniel.baluta at gmail.com
Tue Oct 20 10:30:24 EEST 2015


On Tue, Oct 20, 2015 at 2:28 AM, Cristina Moraru
<cristina.moraru09 at gmail.com> wrote:
> Simplify function return flow. Issue found
> with coccinelle.
>
> Signed-off-by: Cristina Moraru <cristina.moraru09 at gmail.com>

Looks good, ship it! :)

> ---
>  drivers/staging/comedi/drivers/daqboard2000.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index 611b0a3..57ab668 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
>                 return result;
>
>         s = &dev->subdevices[2];
> -       result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
> -                                 dioP2ExpansionIO8Bit);
> -       if (result)
> -               return result;
> -
> -       return 0;
> +       return subdev_8255_init(dev, s, daqboard2000_8255_cb,
> +                               dioP2ExpansionIO8Bit);
>  }
>
>  static void daqboard2000_detach(struct comedi_device *dev)
> --
> 1.9.1
>


More information about the firefly mailing list