[PATCH 0/5] staging: iio: Remove unnecessary explicit comparisons

Daniel Baluta daniel.baluta at gmail.com
Mon Oct 19 13:19:16 EEST 2015


On Mon, Oct 19, 2015 at 1:16 PM, Cristina-Gabriela Moraru
<cristina.moraru09 at gmail.com> wrote:
>
> 2015-10-19 11:09 GMT+03:00 Daniel Baluta <daniel.baluta at gmail.com>:
>>
>> On Mon, Oct 19, 2015 at 2:29 AM, Cristina Moraru
>> <cristina.moraru09 at gmail.com> wrote:
>> > Remove comparisons to 0 or NULL in order to provide efficiency.
>> > Done with coccinelle
>> > @replace@
>> > identifier e;
>> > @@
>> > (
>> > -e == 0
>> > + !e
>> > |
>> > -e != 0
>> > + e
>> > |
>> > -e == NULL
>> > + !e
>> > |
>> > -e != NULL
>> > + e
>> > )
>> >
>> > Cristina Moraru (5):
>> >   staging: iio: Remove unnecessary explicit comparisons
>> >   staging: iio: Remove unnecessary explicit comparisons
>> >   staging: iio: Remove unnecessary explicit comparisons
>> >   staging: iio: Remove unnecessary explicit comparisons
>> >   staging: iio: Remove unnecessary explicit comparisons
>>
>> So you have one patch per directory, that's good! Please
>> add also the directory name in the subject in order to have
>> different subjects for patches otherwise Greg will be confused.
>>
>> e.g.
>>
>>   staging: iio: adc: Remove unnecessary explicit comparisons
>>
>>
>> thanks,
>> Daniel.
>
>
> First 4 pathches are 1 patch per directory. Since in the other directories
> had 1 or at most 2 errors each I combined them in a patch. Should I somehow
> update the last patch subject ?

Please split the last patch in several patches, one per directory. After this
your patch series will have around 9 patches, which is fine.


More information about the firefly mailing list