[PATCH 1/5] staging: iio: Remove unnecessary explicit comparisons

Cristina Moraru cristina.moraru09 at gmail.com
Mon Oct 19 02:29:56 EEST 2015


Remove comparisons to 0 or NULL in order to provide efficiency

Signed-off-by: Cristina Moraru <cristina.moraru09 at gmail.com>
---
 drivers/staging/iio/adc/ad7192.c    |  4 ++--
 drivers/staging/iio/adc/ad7280a.c   |  6 +++---
 drivers/staging/iio/adc/mxs-lradc.c | 10 +++++-----
 drivers/staging/iio/adc/spear_adc.c |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index fe56fb6..beb31d3 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -330,7 +330,7 @@ static ssize_t ad7192_write_frequency(struct device *dev,
 	ret = kstrtoul(buf, 10, &lval);
 	if (ret)
 		return ret;
-	if (lval == 0)
+	if (!lval)
 		return -EINVAL;
 
 	mutex_lock(&indio_dev->mlock);
@@ -625,7 +625,7 @@ static int ad7192_probe(struct spi_device *spi)
 	}
 
 	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
-	if (indio_dev == NULL)
+	if (!indio_dev)
 		return -ENOMEM;
 
 	st = iio_priv(indio_dev);
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index edbfba1..5c731b6 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -365,7 +365,7 @@ static int ad7280_chain_setup(struct ad7280_state *st)
 
 	for (n = 0; n <= AD7280A_MAX_CHAIN; n++) {
 		__ad7280_read32(st, &val);
-		if (val == 0)
+		if (!val)
 			return n - 1;
 
 		if (ad7280_check_crc(st, val))
@@ -686,7 +686,7 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
 	int i, ret;
 
 	channels = kcalloc(st->scan_cnt, sizeof(*channels), GFP_KERNEL);
-	if (channels == NULL)
+	if (!channels)
 		return IRQ_HANDLED;
 
 	ret = ad7280_read_all_channels(st, st->scan_cnt, channels);
@@ -839,7 +839,7 @@ static int ad7280_probe(struct spi_device *spi)
 	struct iio_dev *indio_dev;
 
 	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
-	if (indio_dev == NULL)
+	if (!indio_dev)
 		return -ENOMEM;
 
 	st = iio_priv(indio_dev);
diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index 3f7715c..88bd084 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -566,7 +566,7 @@ static unsigned mxs_lradc_read_ts_pressure(struct mxs_lradc *lradc,
 	m1 = mxs_lradc_read_raw_channel(lradc, ch1);
 	m2 = mxs_lradc_read_raw_channel(lradc, ch2);
 
-	if (m2 == 0) {
+	if (!m2) {
 		dev_warn(lradc->dev, "Cannot calculate pressure\n");
 		return 1 << (LRADC_RESOLUTION - 1);
 	}
@@ -1217,7 +1217,7 @@ static int mxs_lradc_trigger_init(struct iio_dev *iio)
 	struct mxs_lradc *lradc = iio_priv(iio);
 
 	trig = iio_trigger_alloc("%s-dev%i", iio->name, iio->id);
-	if (trig == NULL)
+	if (!trig)
 		return -ENOMEM;
 
 	trig->dev.parent = lradc->dev;
@@ -1608,14 +1608,14 @@ static int mxs_lradc_probe(struct platform_device *pdev)
 		return PTR_ERR(lradc->clk);
 	}
 	ret = clk_prepare_enable(lradc->clk);
-	if (ret != 0) {
+	if (ret) {
 		dev_err(dev, "Failed to enable the delay unit clock\n");
 		return ret;
 	}
 
 	touch_ret = mxs_lradc_probe_touchscreen(lradc, node);
 
-	if (touch_ret == 0)
+	if (!touch_ret)
 		lradc->buffer_vchans = BUFFER_VCHANS_LIMITED;
 	else
 		lradc->buffer_vchans = BUFFER_VCHANS_ALL;
@@ -1692,7 +1692,7 @@ static int mxs_lradc_probe(struct platform_device *pdev)
 		goto err_dev;
 
 	/* Register the touchscreen input device. */
-	if (touch_ret == 0) {
+	if (!touch_ret) {
 		ret = mxs_lradc_ts_register(lradc);
 		if (ret)
 			goto err_ts_register;
diff --git a/drivers/staging/iio/adc/spear_adc.c b/drivers/staging/iio/adc/spear_adc.c
index c538237..d721242 100644
--- a/drivers/staging/iio/adc/spear_adc.c
+++ b/drivers/staging/iio/adc/spear_adc.c
@@ -192,7 +192,7 @@ static int spear_adc_write_raw(struct iio_dev *indio_dev,
 
 	if ((val < SPEAR_ADC_CLK_MIN) ||
 		(val > SPEAR_ADC_CLK_MAX) ||
-		(val2 != 0)) {
+		val2) {
 		ret = -EINVAL;
 		goto out;
 	}
-- 
1.9.1



More information about the firefly mailing list