[PATCH] staging: fbtft: Fix comment style warning

Daniel Baluta daniel.baluta at gmail.com
Wed Oct 14 10:24:49 EEST 2015


Let's not add 'warning' in the commit subject.

We should always try to explain why the commit is needed. What it does should be
obvious from the code.

e.g

staging: fbtft: Fix multi-line comment style

Thus using the preferred style for multi-line coments as
mentioned in Documentation/CodingStyle.

It also silences 'Block comments use * on subsequent lines'
checkpatch.pl warnings.

Other than that, the commit looks good.

thanks,
Daniel.

On Wed, Oct 14, 2015 at 1:54 AM, Cristina Moraru
<cristina.moraru09 at gmail.com> wrote:
> Fix 'Block comments use * on subsequent lines'
> checkpatch.pl warnings
>
> Signed-off-by: Cristina Moraru <cristina.moraru09 at gmail.com>
> ---
>  drivers/staging/fbtft/fb_ssd1351.c | 40 +++++++++++++++++++-------------------
>  1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_ssd1351.c b/drivers/staging/fbtft/fb_ssd1351.c
> index eb45b27..cef33e4 100644
> --- a/drivers/staging/fbtft/fb_ssd1351.c
> +++ b/drivers/staging/fbtft/fb_ssd1351.c
> @@ -97,26 +97,26 @@ static int set_var(struct fbtft_par *par)
>  }
>
>  /*
> -       Grayscale Lookup Table
> -       GS1 - GS63
> -       The driver Gamma curve contains the relative values between the entries
> -       in the Lookup table.
> -
> -       From datasheet:
> -       8.8 Gray Scale Decoder
> -
> -               there are total 180 Gamma Settings (Setting 0 to Setting 180)
> -               available for the Gray Scale table.
> -
> -               The gray scale is defined in incremental way, with reference
> -               to the length of previous table entry:
> -                       Setting of GS1 has to be >= 0
> -                       Setting of GS2 has to be > Setting of GS1 +1
> -                       Setting of GS3 has to be > Setting of GS2 +1
> -                       :
> -                       Setting of GS63 has to be > Setting of GS62 +1
> -
> -*/
> + * Grayscale Lookup Table
> + * GS1 - GS63
> + * The driver Gamma curve contains the relative values between the entries
> + * in the Lookup table.
> + *
> + * From datasheet:
> + * 8.8 Gray Scale Decoder
> + *
> + *     there are total 180 Gamma Settings (Setting 0 to Setting 180)
> + *     available for the Gray Scale table.
> + *
> + *     The gray scale is defined in incremental way, with reference
> + *     to the length of previous table entry:
> + *             Setting of GS1 has to be >= 0
> + *             Setting of GS2 has to be > Setting of GS1 +1
> + *             Setting of GS3 has to be > Setting of GS2 +1
> + *             :
> + *             Setting of GS63 has to be > Setting of GS62 +1
> + *
> + */
>  static int set_gamma(struct fbtft_par *par, unsigned long *curves)
>  {
>         unsigned long tmp[GAMMA_NUM * GAMMA_LEN];
> --
> 1.9.1
>


More information about the firefly mailing list