[PATCH 1/7] staging: rtl8192u: Fix spacing errors
Daniel Baluta
daniel.baluta at gmail.com
Mon Oct 12 11:28:21 EEST 2015
On Mon, Oct 12, 2015 at 8:46 AM, Cristina Moraru
<cristina.moraru09 at gmail.com> wrote:
> Fix multiple checkpatch spacing errors
Lets be more specific, things like "multiple spacing errors" can mean
a lot of things.
I would say:
===
This patch makes code more closer to the Linux kernel coding style
fixing the following
types of errors:
* spaces are && ( a&&b => a && b)
* no space when using increment operation (a ++ => a++)
* space after comma in function param list ( foo(a,b) => foo(a, b) )
* spaces around arithmetic operators ( a+b => a + b)
* space between closing parenthesis and opening brace ( if(a){ => if (a) { )
Errors reported by checkpatch.pl
===
>
> Signed-off-by: Cristina Moraru <cristina.moraru09 at gmail.com>
> ---
<snip>
> u8 WinSize = pHTInfo->RxReorderWinSize;
> - u16 WinEnd = (pTS->RxIndicateSeq + WinSize -1)%4096;
> + u16 WinEnd = (pTS->RxIndicateSeq + WinSize - 1)%4096;
Shouldn't we add spaces also around %
thanks,
Daniel.
More information about the firefly
mailing list