[PATCH 1/3] staging: iio: light: isl29018: Remove non-standard sysfs attributes

Daniel Baluta daniel.baluta at intel.com
Thu Feb 19 10:24:08 EET 2015


On Thu, Feb 19, 2015 at 2:40 AM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This patch removes non-standard sysfs attributes range, range_available,
> adc_resolution and adc_resolution_available. It also removes the
> corresponding show and store functions.
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>

A good commit message should concentrate more on "Why?" do we need
the change instead on "What?" the code does.

The "What" part should be obvious from the code.

So, at the bottom of the commit message we should also say:

This is in preparation for using standard IIO attributes in order to move
the code out of staging.

thanks,
Daniel.


More information about the firefly mailing list