[RFC PATCH 2/3] iio: Move userspace applications from drivers/staging/iio/Documentation/ to tools/iio/

Daniel Baluta daniel.baluta at gmail.com
Fri Feb 6 09:59:18 EET 2015


On Sun, Feb 1, 2015 at 2:03 AM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This patch moves iio userspace applications from drivers/staging/iio/Documentation/
> to tools/iio/ since tools/ directory is the proper place for this kind of
> files.
>
> It also adds tools/iio/ to MAINTAINERS file.
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
> ---
>  MAINTAINERS                                        |   1 +
>  drivers/staging/iio/Documentation/generic_buffer.c | 360 -----------
>  .../staging/iio/Documentation/iio_event_monitor.c  | 308 ----------
>  drivers/staging/iio/Documentation/iio_utils.h      | 683 ---------------------
>  drivers/staging/iio/Documentation/lsiio.c          | 163 -----
>  tools/iio/generic_buffer.c                         | 360 +++++++++++
>  tools/iio/iio_event_monitor.c                      | 308 ++++++++++
>  tools/iio/iio_utils.h                              | 683 +++++++++++++++++++++
>  tools/iio/lsiio.c                                  | 163 +++++
>  9 files changed, 1515 insertions(+), 1514 deletions(-)
>  delete mode 100644 drivers/staging/iio/Documentation/generic_buffer.c
>  delete mode 100644 drivers/staging/iio/Documentation/iio_event_monitor.c
>  delete mode 100644 drivers/staging/iio/Documentation/iio_utils.h
>  delete mode 100644 drivers/staging/iio/Documentation/lsiio.c
>  create mode 100644 tools/iio/generic_buffer.c
>  create mode 100644 tools/iio/iio_event_monitor.c
>  create mode 100644 tools/iio/iio_utils.h
>  create mode 100644 tools/iio/lsiio.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9cff717..853191a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4860,6 +4860,7 @@ S:        Maintained
>  F:     drivers/iio/
>  F:     drivers/staging/iio/
>  F:     include/linux/iio/
> +F:     tools/iio/

I think we have some more things to do before moving this
out of staging:

* create a Makefile in tools/iio/ to easily get lsiio, iio_event_monitor
  and generic buffer executables.
* refactor iio_utils.h. There are some horrible inline functions there.
Perhaps it's better to add them in a separate iio_utils.c file and link
the object file where is needed.

thanks,
Daniel.


More information about the firefly mailing list