[PATCH] staging: rtl8723au: Fix checkpatch error.

Daniel Baluta daniel.baluta at gmail.com
Tue Sep 30 17:55:23 EEST 2014


Commit message should be more specific:

e.g staging: rtl8723au: Fix open braces position


On Tue, Sep 30, 2014 at 5:07 PM, Mihaela Gaman <mp.gaman at gmail.com> wrote:
> This fixes the checkpatch errors:
>         "that open brace { should be on the previous line".
>
> Signed-off-by: Mihaela Gaman <mp.gaman at gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index bc3b8ed..56779cc 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -512,8 +512,7 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
>                 psta->state = _FW_LINKED;
>                 spin_unlock_bh(&psta->lock);
>
> -       }
> -       else
> +       } else
>                 DBG_8723A("add_RATid23a_bmc_sta error!\n");
>  }
>
> @@ -1744,10 +1743,8 @@ void sta_info_update23a(struct rtw_adapter *padapter, struct sta_info *psta)
>         if (WLAN_STA_HT&flags) {
>                 psta->htpriv.ht_option = true;
>                 psta->qos_option = 1;
> -       }
> -       else {
> +       } else
>                 psta->htpriv.ht_option = false;
> -       }
>
>         if (!pmlmepriv->htpriv.ht_option)
>                 psta->htpriv.ht_option = false;

You should fix *all* errors of this type in rtw_ap.c, there are more
then 10 errors like this.

Are you using staging-next branch of staging.git tree? The code from
my tree looks different.

https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/

thanks,
Daniel.


More information about the firefly mailing list