[PATCH v2] staging: slicoss: Remove return statement in void function

Daniel Baluta daniel.baluta at gmail.com
Sun Sep 28 12:58:43 EEST 2014


On Sun, Sep 28, 2014 at 11:48 AM, Vlad Dogaru <ddvlad at herebedragons.ro> wrote:
> On 9/28/2014 11:28 AM, Georgiana Chelu wrote:
>> I was thinking that is not a good idea, but I tried :)) .
>>
>> I used "commit -s -v" command, but there is no "---" under
>> the "Signed-off-by". What did I miss?
>>
>> In the picture is how the commit looks.
>
> The three dashes are added automatically between the commit message
> (inclusing Signed-off-by) and the rest of the patch when viewing the
> patch, like with git show, git log -p, or git format-patch.

As Vlad said, the scissor line ("---") are added when creating the patch file
with git format-patch.

Then, you'll add your comments editing the .patch file.

thanks,
Daniel.


More information about the firefly mailing list