[PATCH v2] staging: slicoss: Remove return statement in void function

[Georgiana Chelu]

I was thinking that is not a good idea, but I tried :)) .

I used "commit -s -v" command, but there is no "---" under
the "Signed-off-by". What did I miss?

In the picture is how the commit looks.

​
Thank you,
Georgiana



On 28 September 2014 09:42, Daniel Baluta <daniel.baluta at gmail.com> wrote:

> On Sun, Sep 28, 2014 at 12:21 AM, Georgiana Chelu
> <georgiana.chelu93 at gmail.com> wrote:
> > Fix the following checkpatch.pl warning:
> > WARNING: void function return statements are not generally useful
> >
> > Signed-off-by: Georgiana Chelu <georgiana.chelu93 at gmail.com>
> > ---
> > changes in V2:
> > * more specific commit message
> > --- //this line shouldn't be here :)
> Do not add --- by hand! Commit should look like this:
>
> > Fix the following checkpatch.pl warning:
> > WARNING: void function return statements are not generally useful
> >
> > Signed-off-by: Georgiana Chelu <georgiana.chelu93 at gmail.com>
> > ---
> > changes in V2:
> > * more specific commit message
> >  drivers/staging/slicoss/slicoss.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/slicoss/slicoss.c
> b/drivers/staging/slicoss/slicoss.c
>
> Otherwise, it looks good. But as I said it's a duplicate.
>
> Daniel.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rosedu.org/pipermail/firefly/attachments/20140928/7dd2cb8e/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: snapshot2.png
Type: image/png
Size: 119263 bytes
Desc: not available
URL: <http://lists.rosedu.org/pipermail/firefly/attachments/20140928/7dd2cb8e/attachment-0001.png>