[PATCH 1/3] staging: iio: light: Fix quoted string split across lines
Daniel Baluta
daniel.baluta at gmail.com
Thu Sep 25 13:55:06 EEST 2014
On Thu, Sep 25, 2014 at 1:45 PM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This fixes the following checkpatch.pl warning:
> WARNING: quoted string split across lines
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
> ---
> drivers/staging/iio/light/isl29018.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index f4e3ba0..c6fd1f2e 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -547,8 +547,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
> */
> status = regmap_write(chip->regmap, ISL29018_REG_TEST, 0x0);
> if (status < 0) {
> - dev_err(chip->dev, "Failed to clear isl29018 TEST reg."
> - "(%d)\n", status);
> + dev_err(chip->dev,
> + "Failed to clear isl29018 TEST reg.(%d)\n", status);
> return status;
> }
>
> @@ -558,8 +558,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
> */
> status = regmap_write(chip->regmap, ISL29018_REG_ADD_COMMAND1, 0);
> if (status < 0) {
> - dev_err(chip->dev, "Failed to clear isl29018 CMD1 reg."
> - "(%d)\n", status);
> + dev_err(chip->dev,
> + "Failed to clear isl29018 CMD1 reg.(%d)\n", status);
> return status;
> }
Better:
if (status < 0) {
- dev_err(chip->dev, "Failed to clear isl29018 TEST reg."
- "(%d)\n", status);
+ dev_err(chip->dev, "Failed to clear isl29018 TEST reg.(%d)\n",
+ status);
return status;
}
@@ -558,8 +558,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
*/
status = regmap_write(chip->regmap, ISL29018_REG_ADD_COMMAND1, 0);
if (status < 0) {
- dev_err(chip->dev, "Failed to clear isl29018 CMD1 reg."
- "(%d)\n", status);
+ dev_err(chip->dev, "Failed to clear isl29018 CMD1 reg.(%d)\n",
+ status);
return status;
}
Be careful with aligning 'status' parameter, under the next
character after open parenthesis of the previous line.
thanks,
Daniel.
More information about the firefly
mailing list