[PATCH] staging: rts5208: add parenthesis to macros

Daniel Baluta daniel.baluta at gmail.com
Wed Sep 24 11:58:41 EEST 2014


On Wed, Sep 24, 2014 at 11:53 AM, Roxana Blaj
<roxanagabriela10 at gmail.com> wrote:
> This fixes the error:

This fixes checkpatch.pl error:

> ERROR: Macros with complex values should be enclosed in parenthesis
>
> Signed-off-by: Roxana Blaj <roxanagabriela10 at gmail.com>
> ---
>  drivers/staging/rts5208/trace.h | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rts5208/trace.h b/drivers/staging/rts5208/trace.h
> index a9ab407..985cb9d 100644
> --- a/drivers/staging/rts5208/trace.h
> +++ b/drivers/staging/rts5208/trace.h
> @@ -80,8 +80,14 @@ static inline char *filename(char *path)
>                 goto label;                                             \
>         } while (0)
>  #else
> -#define TRACE_RET(chip, ret)   return ret
> -#define TRACE_GOTO(chip, label)        goto label
> +#define TRACE_RET(chip, ret)
> +       do {
> +               return ret;
> +       } while (0)
> +#define TRACE_GOTO(chip, label)
> +       do {
> +               goto label;
> +       } while (0)
>  #endif
>
>  #endif  /* __REALTEK_RTSX_TRACE_H */

Otherwise, this looks good! Thanks Roxana!


More information about the firefly mailing list