[PATCH v2] dgnc: Replace non-standard spinlock's macros

Daniel Baluta daniel.baluta at gmail.com
Mon Sep 22 16:25:40 EEST 2014


On Mon, Sep 22, 2014 at 4:01 PM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This patch replaces non-standard spinlock's macros.
> It is done using coccinelle and the following semantic patch:
>
> @@
> expression x;
> @@
>
> - DGNC_SPINLOCK_INIT(x)
> + spin_lock_init(&x)
>
> @@
> expression x,y;
> @@
>
> - DGNC_LOCK(x, y)
> + spin_lock_irqsave(&x, y)
>
> @@
> expression x,y;
> @@
>
> - DGNC_UNLOCK(x, y)
> + spin_unlock_irqrestore(&x, y)
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
> ---
> Changes since v1:
>         -use ' instead of ` in subject and description
>         -remove unnecessary braces around x
>

Make sure to  remove changes since v1 :), when sending to opw-list.

Looks good. Ship it! :)


More information about the firefly mailing list