[PATCH] staging: rts5208: fix code indentation

Vlad Dogaru ddvlad at herebedragons.ro
Sun Sep 21 17:12:34 EEST 2014


On 9/21/2014 1:31 PM, Roxana Blaj wrote:
> This fixes the warning:
> WARNING: suspect code indent for conditional statements (16, 16)
> 
> Signed-off-by: Roxana Blaj <roxanagabriela10 at gmail.com>
> ---
>  drivers/staging/rts5208/ms.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> index 4e48324..ac36545 100644
> --- a/drivers/staging/rts5208/ms.c
> +++ b/drivers/staging/rts5208/ms.c
> @@ -914,9 +914,8 @@ static int ms_read_attribute_info(struct rtsx_chip *chip)
>  		if ((buf[cur_addr_off + 8] == 0x10) ||
>  			(buf[cur_addr_off + 8] == 0x13))
>  #else
> -		if (buf[cur_addr_off + 8] == 0x10)
> +		if (buf[cur_addr_off + 8] == 0x10) {
>  #endif
> -		{
>  			sys_info_addr = ((u32)buf[cur_addr_off + 0] << 24) |
>  				((u32)buf[cur_addr_off + 1] << 16) |
>  				((u32)buf[cur_addr_off + 2] << 8) |

This doesn't look good.  You're moving the open brace on the same line
as the 'if' statement for the "#else" case, but not for the "#if" one.


More information about the firefly mailing list