[PATCH] staging: dgnc: Move open brace on the previous line

[Daniel Baluta]

On Wed, Sep 17, 2014 at 1:07 AM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This fixes the following checkpatch.pl errors:
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index 7602cdf..11acb5d 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -93,8 +93,7 @@ static struct digi_t dgnc_digi_init = {
>   * This defines a raw port at 9600 baud, 8 data bits, no parity,
>   * 1 stop bit.
>   */
> -static struct ktermios DgncDefaultTermios =
> -{
> +static struct ktermios DgncDefaultTermios = {
>         .c_iflag =      (DEFAULT_IFLAGS),       /* iflags */
>         .c_oflag =      (DEFAULT_OFLAGS),       /* oflags */
>         .c_cflag =      (DEFAULT_CFLAGS),       /* cflags */
> @@ -876,8 +875,7 @@ void dgnc_carrier(struct channel_t *ch)
>          *  "make pretend that carrier is there".
>          */
>         if ((virt_carrier == 0) && ((ch->ch_flags & CH_CD) != 0) &&
> -           (phys_carrier == 0))
> -       {
> +           (phys_carrier == 0)) {
>
>                 /*
>                  *   When carrier drops:
> @@ -1083,8 +1081,7 @@ void dgnc_wakeup_writes(struct channel_t *ch)
>
>         if (ch->ch_tun.un_flags & UN_ISOPEN) {
>                 if ((ch->ch_tun.un_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
> -                       ch->ch_tun.un_tty->ldisc->ops->write_wakeup)
> -               {
> +                       ch->ch_tun.un_tty->ldisc->ops->write_wakeup) {
>                         DGNC_UNLOCK(ch->ch_lock, lock_flags);
>                         (ch->ch_tun.un_tty->ldisc->ops->write_wakeup)(ch->ch_tun.un_tty);
>                         DGNC_LOCK(ch->ch_lock, lock_flags);
> @@ -1125,8 +1122,7 @@ void dgnc_wakeup_writes(struct channel_t *ch)
>
>         if (ch->ch_pun.un_flags & UN_ISOPEN) {
>                 if ((ch->ch_pun.un_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
> -                       ch->ch_pun.un_tty->ldisc->ops->write_wakeup)
> -               {
> +                       ch->ch_pun.un_tty->ldisc->ops->write_wakeup) {
>                         DGNC_UNLOCK(ch->ch_lock, lock_flags);
>                         (ch->ch_pun.un_tty->ldisc->ops->write_wakeup)(ch->ch_pun.un_tty);
>                         DGNC_LOCK(ch->ch_lock, lock_flags);

Please run checkpatch.pl your.patch.

Add a space after ")", like this:

> +                       ch->ch_pun.un_tty->ldisc->ops->write_wakeup)<space>{

Otherwise looks good!