[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

[Matei Oprea]

ᐧ

On Wed, Sep 17, 2014 at 12:18 AM, Vlad Dogaru <ddvlad at herebedragons.ro>
wrote:

> On 9/17/2014 12:15 AM, Matei Oprea wrote:
> >
> > ᐧ
> >
> > On Wed, Sep 17, 2014 at 12:11 AM, Vlad Dogaru <ddvlad at herebedragons.ro
> > <mailto:ddvlad at herebedragons.ro>> wrote:
> >
> >     On 9/17/2014 12:03 AM, Matei Oprea wrote:
> >     > It's easier to use kcalloc for allocating arrays. While at it
> >     > also remove useless casting value.
> >     >
> >     > Signed-off-by: Matei Oprea <matei at okapistudio.com
> >     <mailto:matei at okapistudio.com>>
> >     > Cc: ROSEdu Kernel Community <firefly at lists.rosedu.org
> >     <mailto:firefly at lists.rosedu.org>>
> >     > ---
> >     >  drivers/scsi/lpfc/lpfc_init.c |    3 +--
> >     >  1 file changed, 1 insertion(+), 2 deletions(-)
> >     >
> >     > diff --git a/drivers/scsi/lpfc/lpfc_init.c
> >     b/drivers/scsi/lpfc/lpfc_init.c
> >     > index a5769a9..aac9a90 100644
> >     > --- a/drivers/scsi/lpfc/lpfc_init.c
> >     > +++ b/drivers/scsi/lpfc/lpfc_init.c
> >     > @@ -4854,8 +4854,7 @@ lpfc_sli_driver_resource_setup(struct
> >     lpfc_hba *phba)
> >     >       }
> >     >
> >     >       if (!phba->sli.ring)
> >     > -             phba->sli.ring = (struct lpfc_sli_ring *)
> >     > -                     kzalloc(LPFC_SLI3_MAX_RING *
> >     > +             phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
> >     >                       sizeof(struct lpfc_sli_ring), GFP_KERNEL);
> >
> >     Also align the second line to the opening paranthesis above.  If
> you're
> >     using vim, use ":set cinoptions=(0" and reindent that line to get a
> >     proper indent.
> >
> >     >       if (!phba->sli.ring)
> >     >               return -ENOMEM;
> >
> >
> > I'm using this plugin for coding style [0]. Anyways, will resend
> >
> > [0] - http://www.vim.org/scripts/script.php?script_id=4369
>
> I am not familiar with the plugin, but it certainly does not reindent
> lines you didn't touch.  Just for curiosity's sake, try to reindent the
> line i mentioned.  Move to it and press "==", without the quotes.
>
> Vlad
>
>
Ok, it works. Thank you, Vlad. Will resend like that.

-- 
Oprea Matei
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rosedu.org/pipermail/firefly/attachments/20140917/5e1dec2b/attachment-0001.html>