[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

Vlad Dogaru ddvlad at herebedragons.ro
Wed Sep 17 00:11:09 EEST 2014


On 9/17/2014 12:03 AM, Matei Oprea wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
> 
> Signed-off-by: Matei Oprea <matei at okapistudio.com>
> Cc: ROSEdu Kernel Community <firefly at lists.rosedu.org>
> ---
>  drivers/scsi/lpfc/lpfc_init.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index a5769a9..aac9a90 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -4854,8 +4854,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
>  	}
>  
>  	if (!phba->sli.ring)
> -		phba->sli.ring = (struct lpfc_sli_ring *)
> -			kzalloc(LPFC_SLI3_MAX_RING *
> +		phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
>  			sizeof(struct lpfc_sli_ring), GFP_KERNEL);

Also align the second line to the opening paranthesis above.  If you're
using vim, use ":set cinoptions=(0" and reindent that line to get a
proper indent.

>  	if (!phba->sli.ring)
>  		return -ENOMEM;


More information about the firefly mailing list