[PATCH] It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value.

[Matei Oprea]

Sent it the 2nd time correctly.

Sorry, forgot to write the subject. Sending it right now.
ᐧ

On Tue, Sep 16, 2014 at 11:58 PM, Vlad Dogaru <ddvlad at herebedragons.ro>
wrote:

> On 9/16/2014 11:42 PM, Matei Oprea wrote:
> > From: Matei Oprea <matei at crunchbang.(none)>
> >
> > Signed-off-by: Matei Oprea <eu at opreamatei.ro>
> > Cc: ROSEdu Kernel Community <firefly at lists.rosedu.org>
>
> The subject (i.e. shortlog) is too long and does not include a subsystem
> name.  Try something like:
>
> scsi: lpfc: use kcalloc instead of kzalloc
>
> And mention removal of the typecast below.
>
> Also fix your git send-email settings (I think) to remove the "From:
> Matei Oprea <matei at crunchbang.(none)>" bit.
>
> > ---
> >  drivers/scsi/lpfc/lpfc_init.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/lpfc/lpfc_init.c
> b/drivers/scsi/lpfc/lpfc_init.c
> > index a5769a9..aac9a90 100644
> > --- a/drivers/scsi/lpfc/lpfc_init.c
> > +++ b/drivers/scsi/lpfc/lpfc_init.c
> > @@ -4854,8 +4854,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba
> *phba)
> >       }
> >
> >       if (!phba->sli.ring)
> > -             phba->sli.ring = (struct lpfc_sli_ring *)
> > -                     kzalloc(LPFC_SLI3_MAX_RING *
> > +             phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
> >                       sizeof(struct lpfc_sli_ring), GFP_KERNEL);
> >       if (!phba->sli.ring)
> >               return -ENOMEM;
> >
>
>
>


-- 
Oprea Matei
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rosedu.org/pipermail/firefly/attachments/20140917/4f8707f9/attachment.html>