[PATCH] staging: speakup: add new line after declarations
Vlad Dogaru
ddvlad at herebedragons.ro
Tue Sep 16 21:57:28 EEST 2014
On 9/16/2014 9:32 PM, Roxana Blaj wrote:
> This fixes the warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Roxana Blaj <roxanagabriela10 at gmail.com>
> ---
> drivers/staging/speakup/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 1cfff16..3f30a1b 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -2239,6 +2239,7 @@ static int vt_notifier_call(struct notifier_block *nb,
> speakup_bs(vc);
> else if (param->c < 0x100) {
> char d = param->c;
> +
> speakup_con_write(vc, &d, 1);
> }
> break;
Did you consider eliminating 'd' altogether? It doesn't help
readability that much and you can also remove the braces along with it.
Thanks,
Vlad
More information about the firefly
mailing list