[firefly] [PATCH v2] staging: speakup: fix checkpatch warning
Daniel Baluta
daniel.baluta at gmail.com
Mon Sep 15 14:14:11 EEST 2014
On Mon, Sep 15, 2014 at 2:06 PM, Roxana Blaj <roxanagabriela10 at gmail.com> wrote:
> This fixes the checkpatch warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Roxana Blaj <roxanagabriela10 at gmail.com>
> ---
> Changes since v1
>
> drivers/staging/speakup/kobjects.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index e0fa50f..bcc7f62 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -907,10 +907,10 @@ static struct kobj_attribute announcements_attribute =
> __ATTR(announcements, S_IWUSR|S_IRUGO, message_show, message_store);
> static struct kobj_attribute characters_attribute =
> __ATTR(characters, S_IWUSR|S_IRUGO, chars_chartab_show,
> - chars_chartab_store);
> + chars_chartab_store);
You should send the patch against the original source code version. Your diff
now is against v1.
Better discard this patch and start from scratch.
> static struct kobj_attribute chartab_attribute =
> __ATTR(chartab, S_IWUSR|S_IRUGO, chars_chartab_show,
> - chars_chartab_store);
> + chars_chartab_store);
> static struct kobj_attribute ctl_keys_attribute =
> __ATTR(ctl_keys, S_IWUSR|S_IRUGO, message_show, message_store);
> static struct kobj_attribute colors_attribute =
More information about the firefly
mailing list