[firefly] [PATCH] staging: speakup: fix checkpatch warning
Daniel Baluta
daniel.baluta at gmail.com
Mon Sep 15 13:30:50 EEST 2014
On Mon, Sep 15, 2014 at 1:15 PM, Roxana Blaj <roxanagabriela10 at gmail.com> wrote:
> This fixes the checkpatch warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Roxana Blaj <roxanagabriela10 at gmail.com>
> ---
> drivers/staging/speakup/kobjects.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index f3463ad..5fc72de 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -906,9 +906,11 @@ static struct kobj_attribute spell_delay_attribute =
> static struct kobj_attribute announcements_attribute =
> __ATTR(announcements, S_IWUSR|S_IRUGO, message_show, message_store);
> static struct kobj_attribute characters_attribute =
> - __ATTR(characters, S_IWUSR|S_IRUGO, chars_chartab_show, chars_chartab_store);
> + __ATTR(characters, S_IWUSR|S_IRUGO, chars_chartab_show,
> + chars_chartab_store);
You should align 'chars_chartab_store' exactly under 'characters' parameter on
the line above, using tabs as much as possible then spaces.
Something like this:
int this_is_a_function_foo(param1,
<tab><tab><tab><tab>ssparam2).
> static struct kobj_attribute chartab_attribute =
> - __ATTR(chartab, S_IWUSR|S_IRUGO, chars_chartab_show, chars_chartab_store);
> + __ATTR(chartab, S_IWUSR|S_IRUGO, chars_chartab_show,
> + chars_chartab_store);
The same here.
> static struct kobj_attribute ctl_keys_attribute =
> __ATTR(ctl_keys, S_IWUSR|S_IRUGO, message_show, message_store);
> static struct kobj_attribute colors_attribute =
thanks,
Daniel.
More information about the firefly
mailing list