[firefly] [PATCH] usb: usbip: fix usbip.h path in userspace tool

Valentina Manea valentina.manea.m at gmail.com
Thu Sep 4 21:58:11 EEST 2014


On Thu, Sep 4, 2014 at 5:14 AM, Greg KH <gregkh at linuxfoundation.org> wrote:
>
>> This patch is a pretty nasty hack to get it to compile within the
>> kernel tree.  I wonder whether we can make this self-contained by
>> duplicating the header's content inside usbip_common.h.
>
> Ick, no, don't do that, use the .h file, that is what it is there for.
>

This leaves 2 options:
a. include the file the way this patch did it
b. include as <linux/usbip.h> and add the relative path in the kernel
tree to include/uapi as include path. the problem with this is that
the previous header, ch9.h, eventually includes other kernel headers
and a path to include/ would also be necessary. plus, there's a
warning about using kernel headers from user space, which is legit.

For the time being, I suppose the first option will do.

Thanks,
Valentina


More information about the firefly mailing list