[PATCH 1/6] staging: rtl8723au: Do not use comparisons on bool tests

[Daniel Baluta]

On Fri, Oct 3, 2014 at 12:33 PM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> On 03.10.2014 12:27, Roberta Dobrescu wrote:
>> This fixes the following coccinelle warning:
>> WARNING: Comparison of bool to 0/1
>>
>> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
>> ---
>>  drivers/staging/rtl8723au/core/rtw_ap.c             | 2 +-
>>  drivers/staging/rtl8723au/core/rtw_cmd.c            | 2 +-
>>  drivers/staging/rtl8723au/core/rtw_mlme.c           | 2 +-
>>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c       | 2 +-
>>  drivers/staging/rtl8723au/core/rtw_pwrctrl.c        | 2 +-
>>  drivers/staging/rtl8723au/core/rtw_wlan_util.c      | 2 +-
>>  drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c | 2 +-
>>  drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c   | 4 ++--
>>  drivers/staging/rtl8723au/hal/usb_halinit.c         | 2 +-
>>  drivers/staging/rtl8723au/include/rtw_mlme.h        | 2 +-
>>  10 files changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
>> index 6b4092f..6ea4a92 100644
>> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
>> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
>> @@ -1657,7 +1657,7 @@ u8 ap_free_sta23a(struct rtw_adapter *padapter, struct sta_info *psta, bool acti
>>       if (!psta)
>>               return beacon_updated;
>>
>> -     if (active == true)
>> +     if (active)
>>       {
>
> I'll move '{' on the previous line. I've missed it.

Please mention this in the commit message. e.g While at this move
misplaced open brace on previous line.