[PATCH] staging: rtl8723au: Fix open brace error.

Daniel Baluta daniel.baluta at gmail.com
Thu Oct 2 21:15:15 EEST 2014


On Thu, Oct 2, 2014 at 8:52 PM, Mihaela Gaman <mp.gaman at gmail.com> wrote:
> This fixes the error:
>         "that open brace { should be on the previous line".
>
> Signed-off-by: Mihaela Gaman <mp.gaman at gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_led.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_led.c b/drivers/staging/rtl8723au/core/rtw_led.c
> index 9fc7404..3ef89ff 100644
> --- a/drivers/staging/rtl8723au/core/rtw_led.c
> +++ b/drivers/staging/rtl8723au/core/rtw_led.c
> @@ -424,8 +424,7 @@ static void SwLedBlink3(struct led_8723a *pLed)
>         if (pLed->BlinkingLedState == RTW_LED_ON) {
>                 SwLedOn23a(padapter, pLed);
>                 RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): turn on\n", pLed->BlinkTimes));
> -       }
> -       else {
> +       } else {
>                 if (pLed->CurrLedState != LED_BLINK_WPS_STOP)
>                         SwLedOff23a(padapter, pLed);
>                 RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): turn off\n", pLed->BlinkTimes));
> @@ -458,12 +457,10 @@ static void SwLedBlink3(struct led_8723a *pLed)
>                                         RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
>                                 }
>                                 pLed->bLedScanBlinkInProgress = false;
> -                       }
> -                       else {
> +                       }       else {
Why the white spaces here?
} else {  is enough.

>                                 if (padapter->pwrctrlpriv.rf_pwrstate != rf_on) {
>                                         SwLedOff23a(padapter, pLed);
> -                               }
> -                               else {
> +                               } else {
>                                         if (pLed->bLedOn)
>                                                 pLed->BlinkingLedState = RTW_LED_OFF;
>                                         else
> @@ -501,12 +498,10 @@ static void SwLedBlink3(struct led_8723a *pLed)
>                                         RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
>                                 }
>                                 pLed->bLedBlinkInProgress = false;
> -                       }
> -                       else {
> +                       } else {
>                                 if (padapter->pwrctrlpriv.rf_pwrstate != rf_on) {
>                                         SwLedOff23a(padapter, pLed);
> -                               }
> -                               else {
> +                               } else {
>                                         if (pLed->bLedOn)
>                                                 pLed->BlinkingLedState = RTW_LED_OFF;
>                                         else
> @@ -539,8 +534,7 @@ static void SwLedBlink3(struct led_8723a *pLed)
>                         if (bStopBlinking) {
>                                 if (padapter->pwrctrlpriv.rf_pwrstate != rf_on) {
>                                         SwLedOff23a(padapter, pLed);
> -                               }
> -                               else {
> +                               } else {
>                                         pLed->CurrLedState = RTW_LED_ON;
>                                         pLed->BlinkingLedState = RTW_LED_ON;
>                                         SwLedOn23a(padapter, pLed);


More information about the firefly mailing list