[PATCH] staging: dgnc: Remove non-standard APR/RAPR printing macros
Daniel Baluta
daniel.baluta at gmail.com
Thu Oct 2 10:16:51 EEST 2014
On Thu, Oct 2, 2014 at 12:42 AM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
>> @@ -278,7 +274,7 @@ static int dgnc_start(void)
>> */
>> rc = register_chrdev(0, "dgnc", &dgnc_BoardFops);
>> if (rc <= 0) {
>> - APR(("Can't register dgnc driver device (%d)\n", rc));
>> + pr_err(DRVSTR": Can't register dgnc driver device (%d)\n", rc);
>> return -ENXIO;
>> }
>
> I'm not sure about these changes from APR to pr_err.
>
> At this point there is no struct device object to pass to dev_dbg.
> I thought about removing the message completely, since there is
> a return err code, but I'm not sure this is the right thing to do.
>
> A second opinion would be very welcome!
Looks good to me.
More information about the firefly
mailing list