[firefly] [PATCH 4/6] csi: lpfc: lpfc_init: use kcalloc for allocating memory

Daniel Baluta daniel.baluta at gmail.com
Tue Mar 18 22:24:10 EET 2014


On Tue, Mar 18, 2014 at 10:18 PM, Matei Oprea <eu at opreamatei.ro> wrote:
> It's easier to use kcalloc for allocating arrays. While at
> it also remove useless casting value
>
> Signed-off-by: Matei Oprea <eu at opreamatei.ro>
> Cc: ROSEdu Kernel Community <firefly at lists.rosedu.org>
> ---
>  drivers/scsi/lpfc/lpfc_init.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index f815a87..0faddad 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -4732,8 +4732,8 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
>
>         if (!phba->sli.ring)
>                 phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
> -                          sizeof(lpfc_sli_ring),
> -                          GFP_KERNEL);
> +                            sizeof(lpfc_sli_ring),
> +                            GFP_KERNEL);
>         if (!phba->sli.ring)
>                 return -ENOMEM;

Something went terribly wrong. Where is the cast removed?

Daniel


More information about the firefly mailing list