[firefly] [PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value
Joe Perches
joe at perches.com
Wed Mar 12 23:35:37 EET 2014
On Wed, 2014-03-12 at 23:20 +0200, Matei Oprea wrote:
> Remove useless casting value returned by k[cmz]alloc
> to (struct lpfc_sli_ring *).
>
> Found using coccinelle
trivial note:
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
[]
> @@ -4731,8 +4731,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
[]
> - phba->sli.ring = (struct lpfc_sli_ring *)
> - kzalloc(LPFC_SLI3_MAX_RING *
> + phba->sli.ring = kzalloc(LPFC_SLI3_MAX_RING *
> sizeof(struct lpfc_sli_ring), GFP_KERNEL);
Using kcalloc would have been even nicer too
phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
sizeof(struct lpfc_sli_ring),
GFP_KERNEL);
More information about the firefly
mailing list