[PATCH] iio: amplifiers: Use right order for type specification

Daniel Baluta daniel.baluta at gmail.com
Tue Dec 16 11:28:40 EET 2014


On Tue, Dec 16, 2014 at 11:23 AM, Daniel Baluta <daniel.baluta at gmail.com> wrote:
> On Sat, Dec 13, 2014 at 1:30 PM, Roberta Dobrescu
> <roberta.dobrescu at gmail.com> wrote:
>> This patch fixes the following checkpatch.pl warning:
>> WARNING: type 'char unsigned' should be specified in [[un]signed]
>> [short|int|long|long long] order
>>
>> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
>> ---
>>  drivers/iio/amplifiers/ad8366.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
>> index ba6f6a9..5917d98 100644
>> --- a/drivers/iio/amplifiers/ad8366.c
>> +++ b/drivers/iio/amplifiers/ad8366.c
>> @@ -31,7 +31,7 @@ struct ad8366_state {
>>  };
>>
>>  static int ad8366_write(struct iio_dev *indio_dev,
>> -                       unsigned char ch_a, char unsigned ch_b)
>> +                       unsigned char ch_a, unsigned char ch_b)
>>  {
>>         struct ad8366_state *st = iio_priv(indio_dev);
>>         int ret;
>
> Nice. Looks good.

One general remark. I think we can improve subject adding
chip name.

E.g for the current patch:

iio: amplifiers: ad8366: Use right order for type specification

Of course, this is valid when changes touch files of a single
chip.

thanks,
Daniel.


More information about the firefly mailing list