[PATCH] iio: pressure: Add blank line after declarations

Daniel Baluta daniel.baluta at gmail.com
Tue Dec 16 11:18:11 EET 2014


On Sat, Dec 13, 2014 at 12:23 PM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
> ---
>  drivers/iio/pressure/mpl115.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/pressure/mpl115.c b/drivers/iio/pressure/mpl115.c
> index f5ecd6e..282c59c 100644
> --- a/drivers/iio/pressure/mpl115.c
> +++ b/drivers/iio/pressure/mpl115.c
> @@ -37,6 +37,7 @@ struct mpl115_data {
>  static int mpl115_request(struct mpl115_data *data)
>  {
>         int ret = i2c_smbus_write_byte_data(data->client, MPL115_CONVERT, 0);
> +
>         if (ret < 0)
>                 return ret;
>
> --

Nack. As discussed, lets skip this cases. We really want the error code check
to be grouped with function call.


More information about the firefly mailing list