[PATCH 1/4] iio: accel: Add a blank line after declarations

Daniel Baluta daniel.baluta at gmail.com
Tue Dec 16 11:08:02 EET 2014


On Sat, Dec 13, 2014 at 11:55 AM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
> ---
>  drivers/iio/accel/kxcjk-1013.c | 1 +
>  drivers/iio/accel/mma8452.c    | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 320aa72..70610a4 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1134,6 +1134,7 @@ static const char *kxcjk1013_match_acpi_device(struct device *dev,
>                                                enum kx_chipset *chipset)
>  {
>         const struct acpi_device_id *id;
> +

This is OK.

>         id = acpi_match_device(dev->driver->acpi_match_table, dev);
>         if (!id)
>                 return NULL;
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 3c12d49..a04af56 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -75,6 +75,7 @@ static int mma8452_drdy(struct mma8452_data *data)
>  static int mma8452_read(struct mma8452_data *data, __be16 buf[3])
>  {
>         int ret = mma8452_drdy(data);
> +
This lands in a grey area. We should skip it.
>         if (ret < 0)
>                 return ret;
>         return i2c_smbus_read_i2c_block_data(data->client,
> --
> 1.9.1
>
>


More information about the firefly mailing list