[PATCH 2/4] iio: light: Remove unnecessary else after return

Daniel Baluta daniel.baluta at gmail.com
Tue Dec 16 11:02:03 EET 2014


On Fri, Dec 12, 2014 at 4:31 PM, Roberta Dobrescu
<roberta.dobrescu at gmail.com> wrote:
> This patch fixes the following checkpatch.pl warning
> WARNING: else is not generally useful after a break or return
>
This change is not useful. Lets skip it.

> Signed-off-by: Roberta Dobrescu <roberta.dobrescu at gmail.com>
> ---
>  drivers/iio/light/ltr501.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> index 143277f..eee7d90 100644
> --- a/drivers/iio/light/ltr501.c
> +++ b/drivers/iio/light/ltr501.c
> @@ -171,11 +171,10 @@ static int ltr501_read_raw(struct iio_dev *indio_dev,
>                                 *val = 0;
>                                 *val2 = 5000;
>                                 return IIO_VAL_INT_PLUS_MICRO;
> -                       } else {
> -                               *val = 1;
> -                               *val2 = 0;
> -                               return IIO_VAL_INT;
>                         }
> +                       *val = 1;
> +                       *val2 = 0;
> +                       return IIO_VAL_INT;
>                 case IIO_PROXIMITY:
>                         i = (data->ps_contr & LTR501_CONTR_PS_GAIN_MASK) >>
>                                 LTR501_CONTR_PS_GAIN_SHIFT;
> --
> 1.9.1
>
>


More information about the firefly mailing list