[firefly] [PATCH] net: ipv4: netfilter: ip_tables Fix incorrect type in assignment

Matei Oprea eu at opreamatei.ro
Thu Apr 17 14:49:02 EEST 2014


Some feedback on this?
ᐧ

On Tue, Apr 15, 2014 at 11:34 AM, Matei Oprea <eu at opreamatei.ro> wrote:
> ipt_entry should not be declared as a pure function because
> it depends on global state.
>
> Signed-off-by: Matei Oprea <eu at opreamatei.ro>
> Cc: ROSEdu Kernel Community <firefly at lists.rosedu.org>
> ---
>  net/ipv4/netfilter/ip_tables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c
> index 99e810f..855c0a9 100644
> --- a/net/ipv4/netfilter/ip_tables.c
> +++ b/net/ipv4/netfilter/ip_tables.c
> @@ -278,7 +278,7 @@ static void trace_packet(const struct sk_buff *skb,
>  }
>  #endif
>
> -static inline __pure
> +static inline
>  struct ipt_entry *ipt_next_entry(const struct ipt_entry *entry)
>  {
>         return (void *)entry + entry->next_offset;
> --
> 1.9.2
>



-- 
Oprea Matei


More information about the firefly mailing list