[firefly] [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory
Joe Perches
joe at perches.com
Wed Apr 9 03:04:26 EEST 2014
On Tue, 2014-04-08 at 23:42 +0300, Matei Oprea wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
[]
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
[]
> @@ -4742,12 +4742,14 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
[]
> - if (!phba->sli.ring)
[]
> + if (unlikely(!phba->sli.ring)) {
Why add the unlikely?
Glancing at the code it seems more like that this
should be likely than unlikely.
> + phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
> + sizeof(struct lpfc_sli_ring),
> + GFP_KERNEL);
It'd be nicer looking if aligned better
phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
sizeof(struct lpfc_sli_ring),
GFP_KERNEL);
More information about the firefly
mailing list