[firefly] [PATCH] staging: rtl8192e: use memdup_user instead of kmalloc+copy_from_user

Daniel Baluta daniel.baluta at gmail.com
Thu Oct 24 22:52:17 EEST 2013


On Thu, Oct 24, 2013 at 10:51 PM, Daniel Baluta <daniel.baluta at gmail.com> wrote:
> On Thu, Oct 24, 2013 at 10:49 PM, Teodora Baluta <teobaluta at gmail.com> wrote:
>> Use memdup_user rather than duplicating its implementation. This patch
>> fixes the following coccinelle warnings:
>>
>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:2598:8-15: WARNING opportunity for memdup_user
>> drivers/staging/rtl8192e/rtllib_softmac.c:3594:9-16: WARNING opportunity for memdup_user
>>
>> Signed-off-by: Teodora Baluta <teobaluta at gmail.com>
>
> Make sure that the subject doesn't exceed 80 chars. A good candidate would be:
>
> staging: rtl8192e: use memdup_user to simplify code

Anyhow, it looks good!


More information about the firefly mailing list